[Security Solution] - fixing infinite look on host flyout panel due to lack of memoization #204999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o lack of memoization
PhilippeOberti
added
backport
release_note:skip
PhilippeOberti
requested review from
seanrathier,
angorayc,
animehart,
michaelolo24,
christineweng and
opauloh
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
angorayc
approved these changes
Dec 23, 2024
michaelolo24
approved these changes
Dec 23, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 23, 2024
…o lack of memoization (elastic#204999) ## Summary This PR fixes [an issue](elastic/security-team#11424) raised recently where opening a preview panel for a host of user on top of a flyout already showing a host or user was getting the UI stuck into an infinite loop. While we found a few ways to fix the issue - primarily adding memoization to the UI components within the HostPanel and UserPanel, the approach in this PR fixes the issue at a more root level. Infinite loop behavior https://github.com/user-attachments/assets/92cb60ad-7801-43ec-a247-8943e091b6a8 Issue fixed https://github.com/user-attachments/assets/30b30b42-f32e-4c02-9407-9d0f671d7216 This fix should also potentially bring some performance improvement to all the components that are using the hook (we have a few). (cherry picked from commit 96264d2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 23, 2024
… due to lack of memoization (#204999) (#205104) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] - fixing infinite look on host flyout panel due to lack of memoization (#204999)](#204999) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-23T15:55:30Z","message":"[Security Solution] - fixing infinite look on host flyout panel due to lack of memoization (#204999)\n\n## Summary\r\n\r\nThis PR fixes [an\r\nissue](elastic/security-team#11424) raised\r\nrecently where opening a preview panel for a host of user on top of a\r\nflyout already showing a host or user was getting the UI stuck into an\r\ninfinite loop.\r\n\r\nWhile we found a few ways to fix the issue - primarily adding\r\nmemoization to the UI components within the HostPanel and UserPanel, the\r\napproach in this PR fixes the issue at a more root level.\r\n\r\nInfinite loop behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/92cb60ad-7801-43ec-a247-8943e091b6a8\r\n\r\nIssue fixed\r\n\r\n\r\nhttps://github.com/user-attachments/assets/30b30b42-f32e-4c02-9407-9d0f671d7216\r\n\r\nThis fix should also potentially bring some performance improvement to\r\nall the components that are using the hook (we have a few).","sha":"96264d29237f0b7cfc8c651393f12d248f0d84e0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0"],"title":"[Security Solution] - fixing infinite look on host flyout panel due to lack of memoization","number":204999,"url":"https://github.com/elastic/kibana/pull/204999","mergeCommit":{"message":"[Security Solution] - fixing infinite look on host flyout panel due to lack of memoization (#204999)\n\n## Summary\r\n\r\nThis PR fixes [an\r\nissue](elastic/security-team#11424) raised\r\nrecently where opening a preview panel for a host of user on top of a\r\nflyout already showing a host or user was getting the UI stuck into an\r\ninfinite loop.\r\n\r\nWhile we found a few ways to fix the issue - primarily adding\r\nmemoization to the UI components within the HostPanel and UserPanel, the\r\napproach in this PR fixes the issue at a more root level.\r\n\r\nInfinite loop behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/92cb60ad-7801-43ec-a247-8943e091b6a8\r\n\r\nIssue fixed\r\n\r\n\r\nhttps://github.com/user-attachments/assets/30b30b42-f32e-4c02-9407-9d0f671d7216\r\n\r\nThis fix should also potentially bring some performance improvement to\r\nall the components that are using the hook (we have a few).","sha":"96264d29237f0b7cfc8c651393f12d248f0d84e0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204999","number":204999,"mergeCommit":{"message":"[Security Solution] - fixing infinite look on host flyout panel due to lack of memoization (#204999)\n\n## Summary\r\n\r\nThis PR fixes [an\r\nissue](elastic/security-team#11424) raised\r\nrecently where opening a preview panel for a host of user on top of a\r\nflyout already showing a host or user was getting the UI stuck into an\r\ninfinite loop.\r\n\r\nWhile we found a few ways to fix the issue - primarily adding\r\nmemoization to the UI components within the HostPanel and UserPanel, the\r\napproach in this PR fixes the issue at a more root level.\r\n\r\nInfinite loop behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/92cb60ad-7801-43ec-a247-8943e091b6a8\r\n\r\nIssue fixed\r\n\r\n\r\nhttps://github.com/user-attachments/assets/30b30b42-f32e-4c02-9407-9d0f671d7216\r\n\r\nThis fix should also potentially bring some performance improvement to\r\nall the components that are using the hook (we have a few).","sha":"96264d29237f0b7cfc8c651393f12d248f0d84e0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue raised recently where opening a preview panel for a host of user on top of a flyout already showing a host or user was getting the UI stuck into an infinite loop.
While we found a few ways to fix the issue - primarily adding memoization to the UI components within the HostPanel and UserPanel, the approach in this PR fixes the issue at a more root level.
Infinite loop behavior
Screen.Recording.2024-12-19.at.1.20.02.PM.mov
Issue fixed
Screen.Recording.2024-12-19.at.1.18.46.PM.mov
This fix should also potentially bring some performance improvement to all the components that are using the hook (we have a few).